[PATCH] bookmarks: added invalidate() to bookmark_repo

Paul Molodowitch paulm at luma-pictures.com
Tue Dec 22 11:26:40 CST 2009


> Useful information for next time: the folks here usually use patchbomb
> extension to mail their patches, and _inline_ the patches. We prefer
> this over attaching patches because it allows reviewers to quote the
> code :)
>
> Ah... sorry about the attachment - I saw from the submission guidelines
that you preferred inline... but I was sending from work, where they have
somewhat draconian control over the smtp, and gmail can butcher formatting,
I guess I got lazy. =P  I'll wait until I can get home (or can wrest the
smtp password from a sysadmin) before submitting again.


> The patch looks good to me. It needs to be updated [ setattr(self,
> attr, None) should be changed to delattr(self, attr) after my changes
> in crew ], but otherwise it is alright to me.
>
> Did you already make those changes, or did you mean that you wanted me to
make them and re-submit?

Regardless, thanks for reviewing it!

- Paul
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20091222/0178a162/attachment.htm>


More information about the Mercurial-devel mailing list