[PATCH] bookmarks: added invalidate() to bookmark_repo

[Martin Geisler]

Paul Molodowitch <paulm at luma-pictures.com> writes:

>> Useful information for next time: the folks here usually use patchbomb
>> extension to mail their patches, and _inline_ the patches. We prefer
>> this over attaching patches because it allows reviewers to quote the
>> code :)
>>
> Ah... sorry about the attachment - I saw from the submission guidelines
> that you preferred inline... but I was sending from work, where they have
> somewhat draconian control over the smtp, and gmail can butcher formatting,

Yeah... I think you sent this reply using Gmail? It quotes text wrongly:
the first line you write has a ">" character in the beginning, making it
look like it belongs to Nicolas' mail. Not your fault, of course, I just
wanted to mention it if you've never thought about it. You can see the
mail as I see it here:

  http://www.selenic.com/pipermail/mercurial-devel/2009-December/017677.html

> I guess I got lazy. =P I'll wait until I can get home (or can wrest
> the smtp password from a sysadmin) before submitting again.
>
>> The patch looks good to me. It needs to be updated [ setattr(self,
>> attr, None) should be changed to delattr(self, attr) after my changes
>> in crew ], but otherwise it is alright to me.
>
> Did you already make those changes, or did you mean that you wanted me to
> make them and re-submit?

I think you should make the changes and resubmit. Please also expand
your commit name from "paulm" when you resubmit as we generally prefer
the normal "Firstname Lastname <email>" style.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20091222/8c13dd35/attachment.pgp>