[PATCH] tests highlight, keyword: load extensions with "ext ="

[Martin Geisler]

Christian Ebert <blacktrash at gmx.net> writes:

> * Martin Geisler on Wednesday, December 23, 2009 at 19:19:39 +0100
>> Christian Ebert <blacktrash at gmx.net> writes:
>>> # HG changeset patch
>>> # User Christian Ebert <blacktrash at gmx.net>
>>> # Date 1261590408 0
>>> # Node ID 54b33bcbb23286ec3ed084bf7bc70f42a58677ac
>>> # Parent  bb5ea66789e311349e31ab45f9ced405f89acdc6
>>> tests highlight, keyword: load extensions with "ext ="
>> 
>> Heh, thanks for that patch! :-) I'm smiling because I thought I just
>> did the same changes (in bb5ea66789e3) but then I realized that
>> searching through files name "test-.*[^o][^u][^t]" made me miss a
>> couple :-)
>
> You beat me to it but not entirely ;-) I knew because I just worked on
> test-keyword, and it wasn't included, so I did a
>
> egrep '^hgext\..+=\s*$' test-*
>
> with an interesting result for test-win32ext btw, you might want to
> look into it; I no nothing 'bout win.

Ah, me neither, but this case was easy: the extension prints a warning
where it suggests to the user that he adds "hgext.win32text =" to his
hgrc file. So I changed that too, thanks for the pointer :-)

> Wasn't there a time when setting hgext.ext= was recommended or even
> mandatory?

I believe it was mandatory before this revision:

  changeset:   1889:468730910353
  user:        Thomas Arendsen Hein <thomas at intevation.de>
  date:        Sun Mar 12 13:57:55 2006 +0100
  summary:     Try to import extensions from the hgext module first.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20091223/00f47d4c/attachment.pgp>