FW: Re: EOL: patch.eol=auto setting

Martin Geisler mg at lazybytes.net
Thu Dec 24 13:49:17 CST 2009


alexrayne <alexraynepe196 at lavabit.com> writes:

>> Martin Geisler пишет:
>>>> Maybe this unstable work caused of error on parsing .hgeol? What
>>>> happen if parsing of some string\rules failed?
>>>>     
>>>
>>> Why don't you just try it? Commit a .hgeol file with a syntax error and
>>> you'll get this:
>>>
>>>   % hg status
>>>   hg: config error at .hgeol:3: '='
>>>
>>> You'll actually not be able to commit a fixed .hgeol file unless you
>>> disable the extension... hmm, we better fix that :-)
>>>
>>> Using unknown keywords like "**.txt = foo" is silently ignored, we
>>> should fix that as well.

Fixed in revision 8eddbfba6d7e.

>> i cant beleave that you checkout .hgeol every time for take hgeol
>> setting, i suspect you use working copy of .hgeol, so why you need
>> commiting one? just for sure?

I've tried to explain it already: we want to carry the .hgeol file
around with clones, similarly to how .hgignore is moved around. This was
the main complaint people had about win32text, or at least that's how I
understood it. Another major problem was that patches generated while
win32text was enabled were wrong:

  http://bitbucket.org/tortoisehg/stable/issue/82/

This is hopefully solved with the new patch.eol=auto setting.

Please understand that I've never used win32text -- I only work with
repositories that are consistently in LF format these days. But the
Python guys complained that anything less than what Subversion is
offering would not do. So that is why I try to make a new extension that
can replace win32text.

You might want to go back in the archives and read the discussions we've
already had about win32text:

  http://markmail.org/message/yj4so736t4cfdulv
  http://markmail.org/thread/5volevnxgaisx2sc

> imho, at least for simplify debugging hgeol better to provide some
> setting (maybe in hgrc) that turn off checking that .hgeol under
> version control.

Sure -- I've just pushed a change that makes eol look for .hgeol in the
working copy first, and then in the tip revision if there is no .hgeol
in the working copy.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20091224/0491e70b/attachment.pgp>


More information about the Mercurial-devel mailing list