convert: Perforce source for conversion to Mercurial

Martin Geisler mg at daimi.au.dk
Thu Feb 19 15:31:50 CST 2009


"Frank A. Kingswood" <frank at kingswood-consulting.co.uk> writes:

> Frank Kingswood wrote:
>> convert: Perforce source for conversion to Mercurial.
>
> Apologies for sending this too the general mailing list by accident.
> This new convert source is pretty much self-contained and I hope it
> can still go into 1.2.

I cannot answer that question, but I noticed that your coding style is a
little different compared to the normal style, which is close to PEP8.

I'm referring to the lack of spaces around some binary operators, like
these examples with "%", "+", and "==":

+        cmd = "p4 -G changes -s submitted %s"%path

+                        filename = views[v]+oldname[len(v):]

+            elif f["code"]=="text":

Apart from that its good to see a new source for the convert extension!

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090219/023592b3/attachment.pgp 


More information about the Mercurial-devel mailing list