[PATCH 2 of 2] setup: call identify directly from mercurial.commands

Martin Geisler mg at daimi.au.dk
Tue Feb 24 11:12:43 CST 2009


Steve Borho <steve at borho.org> writes:

>> +    os.environ['HGRCPATH'] = '' # do not read any config file
>
> This line was dropped out of the patch that was finally applied, but I
> think we should put it back in.  Without it, the version detection is
> very fragile.  It seems that any failed extension load causes the code
> below to report 'unknown'.

Right, thanks for noticing! If the .hgrc file loads an extension that
crashes hg, then the version becomes "unknown". I've fixed this in crew
as e5627562b9f2.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090224/c70fec9d/attachment.pgp 


More information about the Mercurial-devel mailing list