[PATCH 2 of 2] hgweb: send HTTP unauthorized error when pulling denied via allowpull setting

Dirkjan Ochtman dirkjan at ochtman.nl
Sat Jan 3 07:06:14 CST 2009

On 03/01/2009 01:34, Mark Edgington wrote:
>           if op == 'pull' and not self.allowpull:
> -            raise ErrorResponse(HTTP_OK, '')
> +            raise ErrorResponse(HTTP_UNAUTHORIZED, 'pull not authorized')
>           # op is None when checking allow/deny_read permissions for a web-browser request
>           elif op == 'pull' or op is None:

This is obviously the right thing to do, but ISTR old clients crashed or 
gave not very useful error messages. Could you check that out?



More information about the Mercurial-devel mailing list