[PATCH 12 of 21] lowercase ui.warn output

[Martin Geisler]

Giorgos Keramidas <keramida at ceid.upatras.gr> writes:

> On Sat, 03 Jan 2009 17:40:10 +0100, Martin Geisler <mg at daimi.au.dk> wrote:
>> # HG changeset patch
>> # User Martin Geisler <mg at daimi.au.dk>
>> # Date 1230999321 -3600
>> # Node ID d9bda830172c0ea740cb49a552ed196b2541e44d
>> # Parent  f4ec1cda51b9179cf69ce2be030dd4d23f09aff0
>> lowercase ui.warn output
>>
>> It is possible that there are scripts that grep for these warning
>> messages, especially the "Hunk #1 FAILED at 0" type of messages.
>
> Please don't change the 'Hunk #XXX ignored at LLL' messages.
>
> Their capitalized version matches what the standard patch(1) utility
> displays, and there may be code out there that depends on them.

Thanks for the feedback! I had hunch that these messages would be from a
standard format like that...

I'll update the patch series when I get some more input.

> At least the following 3 styles of output should be compatible with
> patch(1) IMO:
>
>   % strings /usr/bin/patch | fgrep 'Hunk #'
>   Hunk #%d ignored at %ld.
>   Hunk #%d failed at %ld.
>   Hunk #%d succeeded at %ld

Hehe, that's quite cool! :-)

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090103/f40dfa86/attachment.pgp