[PATCH 2 of 2] hgweb: send HTTP unauthorized error when pulling denied via allowpull setting

Mark Edgington edgimar at gmail.com
Sat Jan 3 12:44:20 CST 2009

> This is obviously the right thing to do, but ISTR old clients crashed or
> gave not very useful error messages. Could you check that out?

I started looking at the 0.9.1 client, and if allowpull = false *WITH
THE UNPATCHED CODE*, you get a traceback when cloning, ending with
File "/usr/lib/python2.5/rfc822.py", line 384, in __getitem__
    return self.dict[name.lower()]
KeyError: 'content-type'

With the patched code, it gives you simply:
requesting all changes
abort: authorization failed

Similar behavior seems to occur for all point releases between 0.9.1 and

Could it be that this patch deals with the crashes you were referring to?



More information about the Mercurial-devel mailing list