[PATCH 0 of 2] Progress indicator and support for pull and update

Dirkjan Ochtman dirkjan at ochtman.nl
Tue Jan 6 08:07:15 CST 2009

Stefano Tortarolo <stefano.tortarolo <at> gmail.com> writes:
> Quick update... I've pushed my patches here:
> http://www.bitbucket.org/astratto/progress

I just reviewed the most recent version of Stefano's core patch.

I have some concerns that the current API is more complex than it needs to be.
Specifically, there are many getters and setters, which in my opinion should be
replaced by simple attributes or property()s. I also think the ui.progress()
call that creates a progresshandler should just be folded into the
progress.createprogress() function.

Additionally, the output abstraction currently happens by splitting off a
'progresshandler' from a 'progressdisplayer', but I have a feeling that this
could well be simpler, for example by collapsing them into a single class
(allowing output to be overridden by using a subclass or mixin).



More information about the Mercurial-devel mailing list