Stop sending patches with underbars, please

Dennis Brakhane brakhane at
Thu Jan 8 06:34:25 CST 2009

On Tue, Jan 6, 2009 at 6:23 PM, Matt Mackall <mpm at> wrote:
> Underbars are ugly, hard to type, and against the Mercurial coding
> style. Stop using them, please.

It's the recommended coding style for Python. I think it would be
helpful to state
more explicitly in BasicCodingStyle which parts of PEP 8 do apply for
mercurial and
which parts do not. From what I see at first glace, it's "PEP 8 except
we do not separate words in variables with underscore and tend to
abbreviate names, and we do not capitalize class names" (I'm not sure
about the last one, but IIRC I've seen "rev" instead of "revision" a
lot; a list of "common variable names" might also prove useful)

More information about the Mercurial-devel mailing list