[PATCH] 1321 (partial): run Python pretxnchangegroup hooks before disk flush

Doug Philips dgou at mac.com
Fri Jan 16 01:15:43 CST 2009


On or about Friday, January 16, 2009, at 01:42AM, Matt Mackall indited:
>I'm convinced we need to do something here.
...
>This would still need a new hook name, and we could provide a way for
>in-process hooks to see the updated repo similar to what you've done.

I like the idea of having an environment variable that can keep hook-y code "in the know" and other code immune.

The question though, is why is a new hook needed?
It seems from what I've read about the pretxnchangeset hook, the "outside visibility" is a bug, not a feature.
As such, why not just fix the bug?

--DOug



More information about the Mercurial-devel mailing list