[PATCH] 1321 (partial): run Python pretxnchangegroup hooks before disk flush
dgou at mac.com
Fri Jan 16 02:08:48 CST 2009
On or about Friday, January 16, 2009, at 02:39AM, Matt Mackall indited:
>On Fri, 2009-01-16 at 02:15 -0500, Doug Philips wrote:
>> The question though, is why is a new hook needed?
>> It seems from what I've read about the pretxnchangeset hook, the "outside visibility" is a bug, not a feature.
>> As such, why not just fix the bug?
>The 'outside visibility' is what lets a hook actually do useful work. As
>such it cannot be fixed.
For the hook itself, which is what the environment variable semi-proposal was going to permit, the pending changeset visibility is the whole point, never meant to say otherwise.
By "outside visibility" I meant "outside of the context of the running hook."
In order for an external hook to see the changes-which-are-still-yet-pending-and-abortable, currently, the changes had to be visible to all other viewers/readers of the repo. Fixing this so that the changes are only visible to the hook itself is what I was suggesting.
And as such, the ability for the non-hook viewers to see the changes too is a bug. Fix the bug, not a big deal?
More information about the Mercurial-devel