[PATCH] 1321 (partial): run Python pretxnchangegroup hooks before disk flush

Matt Mackall mpm at selenic.com
Fri Jan 16 16:03:00 CST 2009


On Fri, 2009-01-16 at 15:46 -0500, Jesse Glick wrote:
> Matt Mackall wrote:
> > writing the temporary index may be expensive, we don't want to do it
> > unless necessary
> 
> While the laziness is good, writing the temporary changesets would be
> less expensive if you only wrote the _delaybuf to the special file,
> rather than making a copy of the 
> entire changelog. For example, in my project, 00changelog.i is
> currently around 7.4Mb, whereas the incremental addition from a
> typical push is only going to be a few Kb.

Oh, probably, I just wanted to see how easily I could get this working.

> The patch might be more cumbersome, though, as revlog.py would likely
> need to change to accommodate a split index file.

There's probably an opener trick here that can avoid this ugliness.

I'm mostly curious if the whole concept actually *works* on a large repo
with existing hook scripts.

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list