[PATCH 0 of 2] Small diffstat updates

Patrick Mézard pmezard at gmail.com
Sat Jan 17 10:38:08 CST 2009


Alexander Solovyov a écrit :
> Hi,
> 
> first patch is just a bug fix when there diff is empty (I've got this
> with merge) 

Another version of [1] plus a test is in crew, thanks.

and second adds possibility to do
> 'hg log --template "{diffstat}"', which I think is quite nice. :-)

I am +0 on this one, I will let you convince someone else :-).

The patch looks correct, here are some remarks:
- Try to use the ctx context instance instead of log.parents()
- Add a test, that's two liners in test-command-template
 
> Of course, this slows down log displaying a lot (1.3s instead of 0.09s
> for a latest 100 changesets), but if you're using it, you should know
> what you are doing. Though maybe there is a way to speed up diff 
> retrieval?
> 
> Also, what do you think about adding a help text about templating, like
> it's done with dates, patterns etc?

+1

--
Patrick Mézard


More information about the Mercurial-devel mailing list