[PATCH] Remove branch closing special case

John Mulligan phlogistonjohn at asynchrono.us
Sat Jan 17 15:07:20 CST 2009


On Sat, Jan 17, 2009 at 09:38:21PM +0100, Bartosz SKOWRON wrote:
> On Sat, Jan 17, 2009 at 8:06 PM, John Mulligan
> <phlogistonjohn at asynchrono.us> wrote:
> 
> > There was no good reason to special case the 'default' branch.
> > Allow the 'default' branch to be closed if the user wants it.
> 
> Why? Is there any discussion about? Cause I haven't seen it and don't
> know you wan't to remove default branch...

The discussion was brief, Matt asked me if I had a good reason to
special case default. I didn't and submitted a patch to remove the
special case.

In the worst case scenario, a user uses --close-branch on a branch in a
repo that he shouldn't have and it gets propogated to the other users. To 
fix the issue, someone else just commits a new cset on top of the default
branch (you can still refer to it by name) and ta-da, its open again.

Then you go and heap scorn on the person who closed the branch they
shouldn't have. :-)




More information about the Mercurial-devel mailing list