[PATCH] Set automatically hg version in win32 installer

[Pascal Quantin]

Hi Patrick,

2009/1/18 Patrick Mézard <pmezard at gmail.com>:
> Pascal Quantin a écrit :
>> # HG changeset patch
>> # User Pascal Quantin < pascal.quantin at gmail.com>
>> # Date 1232239553 -3600
>> # Node ID d0c1165cc6d78e3bc562ad65f6bc6d6b6ff401f4
>> # Parent  e9e5f6ea166494fe372defb6280e0d29727c9a42
>> Set automatically hg version in win32 installer
>>
>> Retrieve hg version from __version__.py file and set it as application version in win32 installer
>>
>> diff --git a/contrib/win32/mercurial.iss b/contrib/win32/mercurial.iss
>> --- a/contrib/win32/mercurial.iss
>> +++ b/contrib/win32/mercurial.iss
>> @@ -3,7 +3,7 @@
>>  [Setup]
>>  AppCopyright=Copyright 2005-2009 Matt Mackall and others
>>  AppName=Mercurial
>> -AppVerName=Mercurial snapshot
>> +AppVerName=Mercurial {code:ExtractVersion|''}
>
> Where does it appear ? I cannot see anything in the installer properties (in explorer).

No I did not change the installer properties as it cannot display a
changeset identity. But it will appread in the installer wizard and in
windows uninstall panel.

>
>>  InfoAfterFile=contrib/win32/postinstall.txt
>>  LicenseFile=COPYING
>>  ShowLanguageDialog=yes
>> @@ -13,7 +13,7 @@
>>  AppUpdatesURL=http://www.selenic.com/mercurial
>>  AppID={{4B95A5F1-EF59-4B08-BED8-C891C46121B3}
>>  AppContact=mercurial at selenic.com
>> -OutputBaseFilename=Mercurial-snapshot
>> +OutputBaseFilename=Mercurial Setup
>
> I am not really fond of filenames with spaces, that's asking for problems. What about MercurialSetup.exe ?

I totally agree with you but I came up to this just after sending the
patch... Feel free to change this or I can send an updated patch if
you want.

Regards,
Pascal.

>
> --
> Patrick Mézard
>