[PATCH] auto rename: best matches and speed improvements UPDATE2

Benoit Boissinot bboissin at gmail.com
Tue Jan 27 11:12:18 CST 2009


On Tue, Jan 27, 2009 at 05:50:07PM +0100, Christian Boos wrote:
> Herbert Griebel wrote:
>> # HG changeset patch
>> # User Herbert Griebel <herbertg at gmx.at>
>> # Date 1222956008 -7200
>> # Node ID 18c6c172e8ddd37a46c91d7c92fd002046ba4760
>> # Parent  f29b674cc2210126c2899d94d882c367a8ea64bc
>> auto rename: best matches and speed improvements
>>
>> The auto rename feature of addremove did not rename to the best match
>> and was very slow. The new implementation fixes this using all matches
>> and using statistics of the file content to speed up the matching.
>> ...
>>   
>
> I just had to cancel an `hg addremove -s80' which was taking forever  
> (probably hours if I had let it terminate). Then I remembered that patch  
> and indeed, with its help, the whole operation succeeded in 1m20s, which  
> is quite acceptable given the size of the changeset (5600 additions, 400  
> removals - obtained by tracking 3rd party releases).
>
> I see that there were some objections to the patch, notably Matt  
> mentioned that the patch needed to be broken in smaller parts. Herbert  
> replied that the patch above was actually already the result of the  
> request split (http://markmail.org/message/52pxvaxoqwdvzb43):

I don't think there was a real opposition to the python version
(http://www.soundboot.com/hg/autorename_bestmatches_and_speed.patch no
longer here), it only needs to be splitted for proper review.

regards,

Benoit

-- 
:wq


More information about the Mercurial-devel mailing list