setup: do not use -c with msgfmt on Solaris (issue1489)

Martin Geisler mg at daimi.au.dk
Thu Jan 29 06:09:20 CST 2009


Benoit Boissinot <benoit.boissinot at ens-lyon.org> writes:

> On Wed, Jan 28, 2009 at 10:32:33AM +0100, Martin Geisler wrote:
>> # HG changeset patch
>> # User Martin Geisler <mg at daimi.au.dk>
>> # Date 1233135135 -3600
>> # Node ID b6c2cb40e66426fff69aaecb0864d009e5d70f49
>> # Parent  5d25b2f59adeca72930be5a8f30f785e1edabb3d
>> setup: do not use -c with msgfmt on Solaris (issue1489)
>> 
>> diff --git a/setup.py b/setup.py
>> --- a/setup.py
>> +++ b/setup.py
>> @@ -139,9 +139,12 @@
>>              pofile = join(podir, po)
>>              modir = join('locale', po[:-3], 'LC_MESSAGES')
>>              mofile = join(modir, 'hg.mo')
>> +            cmd = ['msgfmt', '-v', '-o', mofile, pofile]
>> +            if sys.platform != 'sunos5':
>> +                # msgfmt on Solaris does not know about -c
>> +                cmd.append('-c')
>
> Does the order of the arguments matter?

No, flags and arguments can be interleaved for GNU programs, unlike
Mercurial :-) I can push this tonight if you don't do it before me.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.


More information about the Mercurial-devel mailing list