[RFC] checkpatch.py
Giorgos Keramidas
keramida at ceid.upatras.gr
Sat Jul 4 13:27:33 CDT 2009
On Sat, 04 Jul 2009 14:37:22 +0200, Stefano Mioli <jstevie at gmail.com> wrote:
> Of course I'll need to avoid the recreation of the list of regexes for
> each file.
>
> I'm thinking about moving the call to initchecks() from checkpatch()
> to right before the loop over the arguments, and thus modify
> checkpatch()'s signature to also take a list of checks. I think it's
> also better from a logical point of view.
>
> Would that be the right way?
Yes that would be nice. Right now, what I wrote will run re.compile()
and then throw away the results once for each file. Not very smart.
> Giorgos, thank you for your helpful suggestions and code.
You are welcome :-)
More information about the Mercurial-devel
mailing list