[PATCH] patchbomb: fix From_ in the message's envelope

Greg Ward greg-hg at gerg.ca
Mon Jul 6 08:18:23 CDT 2009

On Sun, Jul 5, 2009 at 6:19 PM, Cedric Duval<cedricduval at free.fr> wrote:
>> Is it possible to add a failing test by running something like
>> "LANG=fr hg email ..."?  That would help ensure this bug stays fixed.
> The problem is that AFAIK apart from the C/POSIX locale, no locale is
> guaranteed to exist on a system. Such a test would only be effective
> for a system with the given locale.

Oh.  Right.  Yeah.  Of course.

How about a comment in the code reminding anyone who touches that line
to run a manual test along the lines of

  LANG=xx hg email

where xx is a non-English locale available on their system?  (If they
have any, that is.)  Just a thought.


More information about the Mercurial-devel mailing list