setlocale (Was: Re: [PATCH] patchbomb: fix From_ in the message's envelope)

Cedric Duval cedricduval at
Mon Jul 6 16:56:12 CDT 2009

So... on the course of implementing this locale test, some weird
behaviors led to an interesting discovery. :) Nowhere do we have
the idiomatic

  locale.setlocale(locale.LC_ALL, '')

for setting up the locales according to the user's environment.

It would allow users to take advantage of, for instance, dates displayed
in a way they are used to (e.g. in 'hg log'), etc.

It also means that we'd have to be more careful where locales may affect
results, and that the current code may have wrong assumptions that will
have to be fixed, but in the long run I think this is worth doing.


PS: the reason I noticed the bug fixed by the original patch despite
the fact that hg does not call setlocale, is that I had the 'crecord'
extension activated, which for some reason has such a setlocale call.

More information about the Mercurial-devel mailing list