performance problem with hg 1.3 over ssh?

[Matt Mackall]

On Wed, 2009-07-08 at 17:04 -0700, Bryan O'Sullivan wrote:
> On Wed, Jul 8, 2009 at 4:55 PM, Bryan O'Sullivan <bos at serpentine.com>
> wrote:
>  
>         Per bisect on my Mac, followed by a manual verification, the
>         first bad revision is:
>         changeset:   8340:fce065538bcf
>         
> 
> There's now a fix for this in crew-stable. 

Please don't backout changes without at least an analysis and comment.
When someone looks at this code a year from now and say "oh look, an
unused arg", they'll likely apply exactly the same patch.

The correct fix is to pass -1 unconditionally to subprocess.Popen
without reintroducing the unused arg to util.popen. Here's a related bug
in Python:

http://bugs.python.org/issue4194

-- 
http://selenic.com : development and support for Mercurial and Linux