[PATCH] mq: qpop now tells which patches are popped

[Steve Borho]

On Fri, Jul 10, 2009 at 2:00 PM, Greg Ward<greg-hg at gerg.ca> wrote:
> On Thu, Jul 9, 2009 at 6:00 PM, Mads Kiilerich<mads at kiilerich.com> wrote:
>> # HG changeset patch
>> # User Mads Kiilerich <mads at kiilerich.com>
>> # Date 1247176743 -7200
>> # Node ID a15c20d8d6b0de43e5f3ce3579e02494277f8fb8
>> # Parent  6cf043b1aa144db317beef7a5ecbbc86e7bed820
>> mq: qpop now tells which patches are popped
>>
> [...]
>> +            for patch in reversed(self.applied[start:end]):
>> +                self.ui.warn(_("popping %s\n") % patch.name)
>
> Shouldn't that be self.ui.status()?  (I think that's the one that is
> turned off by -q, right?)  Or maybe write()?  I mean, let's say we
> bite the bullet and prefix every warning with "warning: ".  Then hg
> qpop will say
>
>  warning: popping foobar.patch
>
> which would be really misleading.  This is just a status message.

Just to give this a little weight, TortoiseHg does treat
ui.write_err() differently than it does ui.write().  Messages sent to
ui.write_err() will be drawn in red.  So we do want to use status/warn
consistently.

--
Steve Borho