Tag caching, at last

Dirkjan Ochtman dirkjan at ochtman.nl
Sat Jul 11 15:01:00 CDT 2009


On Fri, Jul 10, 2009 at 17:34, Greg Ward<greg at gerg.ca> wrote:
> Please let me know what you think.  I'm not convinced that having the
> tag cache in another class is necessary, but it's been very handy for
> me staying sane while juggling multiple implementations.  It also
> leaves us the possibility of leaving in a 'nulltagcache' class, so
> that you can easily revert to 1.3 behaviour if you see tag caching
> bugs between now and 1.4.

I'm +1 on the separate class, if only on the grounds that localrepo is
big enough as it is and separating out some clear unit of behavior
would seem to be a good idea. I also think starting with
just-the-filenodes caching is a good idea as a starting point. We can
always go the final step if we find we need it and it's not too
complex.

Cheers,

Dirkjan



More information about the Mercurial-devel mailing list