Tag caching, at last

Greg Ward greg at gerg.ca
Sun Jul 12 15:58:58 CDT 2009


On Sat, Jul 11, 2009 at 12:15 PM, Simon Heimberg<simohe at besonet.ch> wrote:
> Sounds good. I don't understand all, but I saw one detail: Why don't you
> use atomictempfile for writing the cache file?

Err... ummm... ahh.. because I didn't know about atomictempfile!
Thank you for bringing it to my attention.  I'll update my patch.

> (By the way, what is mode "rt"?)

Huh.  I thought Python's open() supported 't' to explicitly mean
"text".  Yeah, I know that's the default, but Explicit Is Better Than
Implicit.  Turns out I was wrong, at least from reading the docs for
2.6.  I'll remove the 't'.

Thanks for the feedback!

Greg


More information about the Mercurial-devel mailing list