[PATCH] changelog: break import cycle

Greg Ward greg-hg at gerg.ca
Sun Jul 12 16:31:23 CDT 2009


On Sat, Jul 11, 2009 at 5:28 PM, Simon Heimberg<simohe at besonet.ch> wrote:
> # HG changeset patch
> # User Simon Heimberg <simohe at besonet.ch>
> # Date 1247138607 -7200
> # Node ID 2adce8bdc7cc1a22688e55d9991793801db8f98c
> # Parent  225f30ff4c6d7aa63b6711fc4fcf98be9aaa6551
> changelog: break import cycle
>
> by overwriting a method instead of passing a bound method

Where's the cycle?  If you're breaking an import cycle, shouldn't your
patch remove at least one import?

Also, did you mean "overriding" or "overwriting"?  The former is the
normal OO term.

Greg



More information about the Mercurial-devel mailing list