[PATCH 1 of 2] run-tests: make --tmpdir option more useful

Augie Fackler durin42 at gmail.com
Sun Jul 12 17:32:44 CDT 2009


On Jul 12, 2009, at 4:52 PM, Greg Ward wrote:

> On Sun, Jul 12, 2009 at 12:10 PM, Augie Fackler<durin42 at gmail.com>  
> wrote:
>>
>> On Jul 11, 2009, at 5:54 PM, Greg Ward wrote:
>>> # HG changeset patch
>>> # User Greg Ward <greg at gerg.ca>
>>> # Date 1247350616 14400
>>> # Node ID ad3cd96f3eab09436624b230cb9f0830a70e155b
>>> # Parent  54eb3782d32fcc9de072b5e7c9efb6b2bad211c3
>>> run-tests: make --tmpdir option more useful.
>>>
>>> - instead of creating HGTMP inside tmpdir, now HGTMP is tmpdir
>>>  (thus, fail if tmpdir already exists)
>>> - passing --tmpdir automatically turns on --keep-tmpdir
>>
>> I'm going to chime in with a -1 on that - I frequently assign the  
>> tmpdir to
>> be on a RAM disk for speed, and still want the test results to be  
>> blown
>> away. In fact, I've never used --keep-tmpdir.
>
> <snip rationale explanation>
> Any better ideas for how to support those use cases?

I totally *get* the use case of keeping the temporary directory, I'm  
saying that having it on if --tmpdir is specified doesn't seem like  
the behavior I want. For your use case, --tmpdir /tmp/foo --keep- 
tmpdir is sufficient, isn't it?

I typically run the tests and expect no failures, but always specify  
tmpdir to be a RAM disk. Your case requires my use case to run rm -rf  
$HGTMP after every test run.

> Greg

Augie

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2417 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090712/a287af00/attachment.bin 


More information about the Mercurial-devel mailing list