[PATCH 2 of 8] localrepo: rename in-memory tag cache instance attributes

Paul Moore p.f.moore at gmail.com
Mon Jul 13 09:44:00 CDT 2009


2009/7/13 Greg Ward <greg-hg at gerg.ca>:
> On Mon, Jul 13, 2009 at 4:20 AM, timeless<timeless at gmail.com> wrote:
>>> +        # These two define the set of tags for this repository.  _tags
>>> +        # maps tag name to node;
>>
>> my initial response was to say you wanted "nodes", but i think for
>> proper English it would be "maps a tag name to a node".
>
> Counterclaim: the idiom "maps X to Y" is a peculiar special case used
> in math and programming; it appears particularly often in comments and
> docstrings of Python or Java code written by me.  ;-)  I'm speaking of
> "tag name" in the generic sense, not about any particular tag name or
> set of tag names.  Hence, I claim that "maps tag name to node" is
> valid mathematician/programmer English.

FWIW, I find timeless' correction easier to read. I can understand
your argument, and once I have done so, I can see how your usage is OK
in that context. But it still uses more of my (feeble :-)) brainpower
to follow. Practicality beats purity and all that.

Paul.



More information about the Mercurial-devel mailing list