[PATCH] dispatch: modifying an option list without copying it first makes a mess

Matt Mackall mpm at selenic.com
Wed Jul 15 17:55:03 CDT 2009


On Fri, 2009-07-10 at 13:59 +0200, Dan Villiom Podlaski Christiansen
wrote:
> # HG changeset patch
> # User Dan Villiom Podlaski Christiansen <danchr at gmail.com>
> # Date 1247225972 -7200
> # Node ID db5aba03c61248ce61998b17ef39877164c53633
> # Parent  561ff8d9e4f073ced576eff21b535d81d1314b1e
> dispatch: modifying an option list without copying it first makes a mess.
> 
> When one or more option lists refer to the same list instance,
> aliasing each other, updates to one list them will affects the others
> as well. This can lead to changes to options for one command
> inadvertently affecting other commands.

Does this fix something in stock 1.3? In other words, should it be
applied to stable?

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list