[PATCH 4 of 4] bookmarks: optimize update routine in case track.current is set

David Soria Parra sn_ at gmx.net
Thu Jul 23 17:58:35 CDT 2009


# HG changeset patch
# User David Soria Parra <dsp at php.net>
# Date 1248388800 -7200
# Node ID 3ab1a43e7700445ea3bdadd7d55a489c4d161238
# Parent  970d6727696d60e4891e1d3ff3f23aba11ea8e9c
bookmarks: optimize update routine in case track.current is set

diff --git a/hgext/bookmarks.py b/hgext/bookmarks.py
--- a/hgext/bookmarks.py
+++ b/hgext/bookmarks.py
@@ -262,12 +262,13 @@
                     parents = (parents[0],)
                 marks = parse(self)
                 update = False
-                for mark, n in marks.items():
-                    if ui.configbool('bookmarks', 'track.current'):
-                        if mark == current(self) and n in parents:
-                            marks[mark] = node
-                            update = True
-                    else:
+                if ui.configbool('bookmarks', 'track.current'):
+                    mark = current(self)
+                    if mark and marks[mark] in parents:
+                        marks[mark] = node
+                        update = True
+                else:
+                    for mark, n in marks.items():
                         if n in parents:
                             marks[mark] = node
                             update = True


More information about the Mercurial-devel mailing list