[PATCH 1 of 2] run-tests: make --tmpdir option more useful

[Martin Geisler]

Greg Ward <greg at gerg.ca> writes:

> On Thu, Jul 23, 2009 at 12:55 PM, Martin Geisler<mg at lazybytes.net> wrote:
>> After thinking about it on my way home, I think it's the --keep-tmpdir
>> flag that is unneeded. Without it, we would then have exactly two modes:
>>
>> * run-test.py picks a random directory and cleans up automatically.
>>
>> * you pick the directory and you get to clean it up.
>>
>> It seems like a nice feature to be able to specify a fixed directory
>> for the test -- using TMP will merely specify the parent directory
>> for the randomly generated test directory.
>>
>> Greg, what do you think -- you proposed the original patches :-)
>
> Sorry for the long delay.  I've been trying to get work done by hiding
> from my email.  ;-)

Hehe, no worries :-)

> Anyways... I *think* that the patch I sent (back on July 11) is
> actually very close to Martin's idea.  It's just not explicit about
> the "two modes" thing.

I'm pretty sure it is, except that it keeps the --keep-tmpdir flag,
which I believe we don't need anymore.

>  I'll have to take a second look at the patch and refresh my memory.
>
> And I should add something to make Augie happy -- say, if you run
>
>   ./run-tests.py --tmpdir /mnt/ramdisk
>
> where /mnt/ramdisk already exists, maybe the error message should be
>
>   error: temp dir /mnt/ramdisk already exists (did you mean to set TMP?)
>
> (with adjustment for platform-specific environment variable: doesn't
> Windows call it %TEMPDIR% or something?)

That's a good idea, it makes the slightly obscure TMP setting less so.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090730/3de9edbe/attachment.pgp