[PATCH] keyword: English improvement in verbose help

Christian Ebert blacktrash at gmx.net
Tue Jun 9 16:46:25 CDT 2009


Hi Greg,

* Greg Ward on Tuesday, June 09, 2009 at 17:16:57 -0400
> On Tue, Jun 9, 2009 at 4:54 PM, Christian Ebert<blacktrash at gmx.net> wrote:
>> # HG changeset patch
>> # User Christian Ebert <blacktrash at gmx.net>
>> # Date 1244580824 -7200
>> # Node ID f3a1f4d6348e31aead0c1778875fff0c648afbcd
>> # Parent  9c75f16f577c74f2433f63c3bb63458c9b8c7b31
>> keyword: English improvement in verbose help
>> 
>> diff --git a/hgext/keyword.py b/hgext/keyword.py
>> --- a/hgext/keyword.py
>> +++ b/hgext/keyword.py
>> @@ -370,9 +370,9 @@
>>  def files(ui, repo, *pats, **opts):
>>     '''print files currently configured for keyword expansion
>> 
>> -    Crosscheck which files in working directory are potential targets
>> -    for keyword expansion. That is, files matched by [keyword] config
>> -    patterns but not symlinks.
>> +    Crosscheck which files in the working directory are potential
>> +    targets for keyword expansion. That is, files matched by [keyword]
>> +    config patterns but not symlinks.
> 
> That is an improvement, but it's still not grammatically correct.
> Specifically, the second sentence has no verb.  It's easy to fix
> though:
> 
>    Crosscheck which files in the working directory are potential
>    targets for keyword expansion (that is, files matched by [keyword]
>    config patterns but not symlinks).
> 
> That is grammatically correct.  I don't know if it's factually
> correct.  I also don't entirely understand it myself, so there's still
> room for improvement.

There's always room for improvement ;-)

I'll try to describe:

The command is a configuration check (therefore "crosscheck", not
sure about that).

If you are insecure which/what (?) files in the working directory
are candidates for keyword expansion, use "hg kwfiles" to display
the filenames matching the [keyword] configuration pattern(s).
Symbolic links are excluded ... errmh ... because they may not be
overwritten ... perhaps omit the symlink part entirely ... the
only reason I put it in because I was imagining a user who
configures a pattern an wonders file a never appears even though
the filename matches the configured pattern ...

... well ... ;-)

c
-- 
  Was heißt hier Dogma, ich bin Underdogma!
[ What the hell do you mean dogma, I am underdogma. ]
_F R E E_  _V I D E O S_  http://www.blacktrash.org/underdogma/
                          http://www.blacktrash.org/underdogma/index-en.html


More information about the Mercurial-devel mailing list