[PATCH] Remove closed argument from heads

Brodie Rao dackze at gmail.com
Wed Jun 10 07:54:58 CDT 2009


On Jun 10, 2009, at 6:45 AM, John Mulligan wrote:

> On Wed, Jun 10, 2009 at 11:00:07AM +0100, timeless wrote:
>> On Wed, Jun 10, 2009 at 3:19 AM, John
>> Mulligan<phlogistonjohn at asynchrono.us> wrote:
>>> +    If one or more REV is given the "branch-heads" will be shown  
>>> for
>>> +    the branch that REV belongs to.
>>
>> I'm having problems with this statement (ending with "to" is  
>> problematic).
>>
>
> How about: If one or more REV is given the "branch-heads" will be  
> shown
> for the named branch associated with that revision. The name of the
> branch is called the revision's branch tag.

I disagree that ending with a preposition is problematic, but this  
revised sentence is more descriptive.

However, a comma should come after the conditional clause:

> If one or more REV is given, the "branch-heads" will be ...


Also, why the hyphen between branch and head? I don't think there's  
anything to disambiguate, and it isn't consistent with the rest of  
Mercurial (grep branch-head and "branch head"). I would drop the  
hyphen and drop the quotes there as well.


More information about the Mercurial-devel mailing list