[PATCH 1 of 2] acl: upgrade comments to python doc, accessible to online help
timeless
timeless at gmail.com
Thu Jun 18 01:10:29 CDT 2009
2009/6/18 Cédric Duval <cedricduval at free.fr>:
> +'''this hook allows to allow or deny access to parts of a repo
allows <who> ?
and please avoid using both 'allows' and 'allow' together in different roles
> +when taking incoming changesets.
taking => receiving?
> +authorization is against local user name on system where hook is
against => based on the
> +run, not committer of original changeset (since that is easy to
is run => runs
not => not the
> +spoof).
> +acl hook is best to use if you use hgsh to set up restricted shells
i don't like 'best to use'
> +for authenticated users to only push to / pull from.
acl hook should be used with hgsh (which provides shells restricted to
hg pull/push).
> not safe if
It is not safe if...
> +user has interactive shell access, because they can disable hook.
... the user
i don't like 'they', i know some people use it to avoid gender issues,
but 'they' is in my mind plural, and 'the user' is singular.
> +also not safe if remote users share one local account, because then
> +no way to tell remote users apart.
then no way => then there isn't a way to
tell remote users apart => distinguish remote users.
does style really eschew: Sentences written like this. ?
> +allow and deny lists have subtree pattern (default syntax is glob)
'have' is odd, take? support? use? accept?
> +on left, user names on right. deny list checked before allow list.
on _the_; on_the_
More information about the Mercurial-devel
mailing list