[PATCH] bookmarks: Avoid wrapping bundlerepository

[Greg Ward]

On Wed, Jun 24, 2009 at 11:50 AM, Isaac Jurado<diptongo at gmail.com> wrote:
> # HG changeset patch
> # User Isaac Jurado <diptongo at gmail.com>
> # Date 1245858603 -7200
> # Node ID 2b639960ea4e2640a8e80497a24efc566d2fb397
> # Parent  288ba6d6c5c76716e827a69a80938885adf8c7ba
> bookmarks: Avoid wrapping bundlerepository
>
> As bundlerepository inherits from localrepository, Bookmarks wraps it altering
> its behaviour in some way.  In particular bundlerepository.__del__ is never
> called so uncompressed bundle files are not deleted from the .hg subdirectory.

Hmmm.  Sounds to me like the real bug is in bundlerepository.  It
should not rely on __del__ being called to cleanup; there should be an
explicit close() method that Hg guarantees will be called.
Unfortunately, I don't see such a beast in the base repo.repository
class, so adding it would be a bit of a chore.  ;-(

Greg