[PATCH] bookmarks: Avoid wrapping bundlerepository
Isaac Jurado
diptongo at gmail.com
Thu Jun 25 11:03:06 CDT 2009
> On Thu, Jun 25, 2009 at 15:34, Greg Ward<greg-hg at gerg.ca> wrote:
> > Hmmm. Sounds to me like the real bug is in bundlerepository. It
> > should not rely on __del__ being called to cleanup; there should be an
> > explicit close() method that Hg guarantees will be called.
> > Unfortunately, I don't see such a beast in the base repo.repository
> > class, so adding it would be a bit of a chore. ;-(
>
> IIRC Isaac came to the conclusion that replacing all mentions of repo
> inside the bookmark_repo's methods with self fixed the problems.
Correct. Forget this patch because the proper fix has already been
queued.
--
Isaac Jurado
http://www.krenel.net
"The noblest pleasure is the joy of understanding."
Leonardo da Vinci
More information about the Mercurial-devel
mailing list