[issue1556] inserve race condition: test-inotify-issue1371 fails

[Marti]

New submission from Marti <intgr at juffo.org>:

There is a race condition in inserve where it fails to detect removed files in
some cases. For instance, this makes test-inotify-issue1371 fail on two of my
computers:

ERROR: test-inotify-issue1371 output changed
--- Expected output 
+++ Test output 
@@ -12,5 +12,4 @@
 A h
 R a
 R e
-! b
 Are we able to kill the service? if not, the service died on some error

As far as I can tell, this is 100% reliable on both computers.

On machine A, I've narrowed the testcase down a bit, however it occurs less
reliably, about 4/5 of the time:

$ hg init a; (cd a; touch b; hg inserve --debug -d; hg ci -Am m; rm -v b; touch
g; hg add g; hg st)
watching ''
status: 'b' None -> ?
adding b
removed `b'
A g

On machine B however, this testcase does not fail. I suppose the speed of the
CPU might make the difference. Both are running Gentoo (no crazy CFLAGS) on x86_64.

A is running kernel 2.6.28.7 compiled for uniprocessor, Athlon 64 3000+
B is running kernel 2.6.24, with SMP, Athlon 64 X2 5600+

----------
messages: 8815
nosy: intgr
priority: bug
status: unread
title: inserve race condition: test-inotify-issue1371 fails

____________________________________________________
Mercurial issue tracker <mercurial-bugs at selenic.com>
<http://www.selenic.com/mercurial/bts/issue1556>
____________________________________________________