[PATCH] inotify: Setting up a non-NULL return value to _inotify.remove_watch
Nicolas Dumazet
nicdumz at gmail.com
Thu Mar 26 03:29:57 CDT 2009
2009/3/26 Nicolas Dumazet <nicdumz at gmail.com>:
> # HG changeset patch
> # User Nicolas Dumazet <nicdumz.commits at gmail.com>
> # Date 1238052263 -32400
> # Node ID fed7e487c58ba7f874f0e468ee31790ab3180904
> # Parent c2ecaf63badee4e973c4d843121139d4d3269f12
> inotify: Setting up a non-NULL return value to _inotify.remove_watch
My misunderstanding.
The .c is indeed buggy.
But the IN_IGNORED mask specifically signals to inotify clients that
since the file was deleted, sys/inotify doesn't watch the file
anymore. Calling the handler _remove is the way to go.
I will re-submit a bit later a corrected version of this path,
adding.... -- tadam -- documentation to avoid falling again in those
holes.
More information about the Mercurial-devel
mailing list