Refactoring util.py

Steve Borho steve at borho.org
Thu Mar 26 22:41:01 CDT 2009


On Thu, Mar 26, 2009 at 10:06 PM, Steve Borho <steve at borho.org> wrote:
> On Thu, Mar 26, 2009 at 2:15 PM, Matt Mackall <mpm at selenic.com> wrote:
>> I just pushed a big refactoring of util. We now have four files:
>>
>> util.py: OS-independent utility functions, which imports:
>>  posix.py: POSIX implementations of some things
>>  windows.py: Windows implementations of some things, which imports:
>>  win32.py: Windows implementations of some things using pywin32
>>
>> As util is still pretty damn big and ugly, I'm planning to go further
>> down this path. Candidates include:
>>
>> - moving date functions into their own module
>> - moving the remainder of the matching functions into match.py
>> - moving the string encoding magic to i18n.py
>
> windows.py is missing patkind()
>
> I would send a patch, but I'm not sure if you want to reference an
> existing copy, or declare a new one.

It's also missing an import of osutil

--
Steve Borho



More information about the Mercurial-devel mailing list