helptext upstream feedback

[Martin Geisler]

Fabian <fabian.kreutz+google at starnet.fi> writes:

> Hi!
>
> I don't have a patch yet, as some of my suggestions contain questions
> or are too large for me to do quickly.
> These are just my thoughts while reading the translatable texts.
>
> 1. Substitutions in help texts should be named, so that a different
> language can use a different order of the arguments. It would also
> help the translator as to what "%s is not a %s:%s" might possibly
> mean.
> (too large for me to provide a patch ;) )

You're right that it would be good for the translators, but it would
also complicate the code a lot. Please see the message here:

  http://markmail.org/message/azlmsym3h7fook5q

> 2. Line 389 in cmdutil.py substitutes an action, which is therefore
> not translated.

Yeah, that's stupid -- I've fixed this in revision caef5fdf1375 in crew.

> 3. Line 976 in commands.py is particularly unhelpful. "check the
> install" is what the command just did.
>   I suggest "Consider the above suggestions" or likewise.
>
> 4. The help text of hg commit should mention that a commit is a local
> action, as people from non-distributed RCS might not know/forget it.

I would like to add something like you suggest, what about:

    Commit changes to the given files into the local repository. See 'hg
    help push' for a means to publish changes to another repository.

What I don't like about this is that there are many other ways to
publish changesets, and maybe the changeset need not be propagated at
all, in case the repository is visible.

> 5. What exactly is the changeset id?

Good question -- the various documentation uses the term to mean both
the revision number and the revision hash, as you've noted.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://selenic.com/pipermail/mercurial-devel/attachments/20090327/f4f161f2/attachment.pgp