[PATCH 1 of 1] grp.* and pwd.* from tarfile are needed for this to work

Giorgos Keramidas keramida at ceid.upatras.gr
Mon Mar 30 12:37:35 CDT 2009


On Mon, 30 Mar 2009 09:36:09 -0400, Greg Ward <greg-hg at gerg.ca> wrote:
> On Sat, Mar 28, 2009 at 7:49 PM, Giorgos Keramidas
> <keramida at ceid.upatras.gr> wrote:
>> # HG changeset patch
>> # User Giorgos Keramidas <keramida at ceid.upatras.gr>
>> # Date 1238284130 -7200
>> # Branch keramida
>> # Node ID 35202f3bdc2e5dfd7ef823e82de594f17e109031
>> # Parent  15b59a407f83f0020e671cda4da970564a078a36
>> grp.* and pwd.* from tarfile are needed for this to work.
>>
>> diff --git a/mercurial/posix.py b/mercurial/posix.py
>> --- a/mercurial/posix.py
>> +++ b/mercurial/posix.py
>> @@ -10,6 +10,7 @@
>>
>>  from i18n import _
>>  import os, sys, osutil, errno, stat, getpass
>> +from tarfile import (grp, pwd)
>
> Bzzzzzt!!  That's Python 2.5 syntax.  I think you meant to say
>
>   from tarfile import grp, pwd
>
> But that's still a very strange way to import top-level modules grp
> and pwd.  Why not just
>
>   import pwd
>   import grp

That's what was pushed into crew.  But I didn't realize `from foo import
(a, b)' was Python 2.5 syntax.  Thanks for the tip :-)




More information about the Mercurial-devel mailing list