[PATCH] localrepo: use set for tag_disallowed
Simon Heimberg
simohe at besonet.ch
Mon May 4 01:21:49 CDT 2009
# HG changeset patch
# User Simon Heimberg <simohe at besonet.ch>
# Date 1241402310 -7200
# Node ID bafd1242ab8f8afe2e5ede2769c08feefbeca759
# Parent 8b73db9fece2d936f9cc694c59a7206ff0829f2d
localrepo: use set for tag_disallowed
diff -r 8b73db9fece2 -r bafd1242ab8f mercurial/localrepo.py
--- a/mercurial/localrepo.py Mon Mai 04 03:49:57 2009 +0200
+++ b/mercurial/localrepo.py Mon Mai 04 03:58:30 2009 +0200
@@ -127,7 +127,7 @@
def hook(self, name, throw=False, **args):
return hook.hook(self.ui, self, name, throw, **args)
- tag_disallowed = ':\r\n'
+ tag_disallowed = set(':\r\n')
def _tag(self, names, node, message, local, user, date, parent=None,
extra={}):
@@ -138,9 +138,10 @@
names = (names,)
else:
allchars = ''.join(names)
- for c in self.tag_disallowed:
- if c in allchars:
- raise util.Abort(_('%r cannot be used in a tag name') % c)
+ disallowed = self.tag_disallowed.intersection(allchars)
+ if disallowed:
+ c = list(disallowed)[0]
+ raise util.Abort(_('%r cannot be used in a tag name') % c)
for name in names:
self.hook('pretag', throw=True, node=hex(node), tag=name,
More information about the Mercurial-devel
mailing list