[PATCH 2 of 3] absolute imports for mercurial modules
Greg Ward
greg-hg at gerg.ca
Mon May 4 08:27:18 CDT 2009
On Sat, May 2, 2009 at 6:52 PM, Martin Geisler <mg at lazybytes.net> wrote:
> Simon Heimberg <simohe at besonet.ch> writes:
>
>> # HG changeset patch
>> # User Simon Heimberg <simohe at besonet.ch>
>> # Date 1240936971 -7200
>> # Node ID da8bb0eb1d2eaacd838399d98d4e6bc764571685
>> # Parent 1c64876cb225e06807c7ec9d00d26e08564fccbc
>> absolute imports for mercurial modules
>
> I personally like this, I think it makes things more explicit. It is
> also more future-proof than the current relative imports.
I'm strongly in favour of Simon's first two patches. As a newcomer to
the Mercurial source, I find the messy imports in most modules make it
unnecessarily hard to follow things.
(Personally, I prefer to put imports from the standard library first,
then imports from 3rd-party libraries, then finally imports from the
local project. That seems to be a fairly common style in many
languages. As long as we're contemplating tinkering like this, what
about a patch to reorder imports like that?)
Greg
More information about the Mercurial-devel
mailing list