[PATCH 1 of 2] color: wrap qdiff/qseries after all extensions are loaded

Augie Fackler durin42 at gmail.com
Thu May 7 22:16:55 CDT 2009


On May 7, 2009, at 11:20 AM, Dirkjan Ochtman wrote:

> On Thu, May 7, 2009 at 6:09 PM, Martin Geisler <mg at lazybytes.net>  
> wrote:
>> At that point color.extsetup will modify mq.cmdtable, but this does  
>> not
>> take effect because mq.cmdtable was already merged with  
>> commands.table.
>
> So color can just manipulate the mq commands in commands.table?
>
> Topo-sorting sounds awkward. Maybe a small registry where extensions
> can register functions to be called when the target extension is
> loaded? If the extension was already loaded, the function fires
> directly; if not, it's fired as soon as the extension is loaded.

That's actually the most compelling solution I've heard for this. That  
would fix the problem for hgsubversion where I want to wrap rebase,  
and also fix the problem of (potentially) wanting to wrap pull after  
rebase has done so.

+1 from me.

> Cheers,
>
> Dirkjan
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list