[RFC] [PATCH] Support arguments in template expandos
Rocco Rutte
pdmef at gmx.net
Fri May 8 07:15:14 CDT 2009
Hi,
* Dirkjan Ochtman wrote:
> On Thu, May 7, 2009 at 6:08 PM, Rocco Rutte <pdmef at gmx.net> wrote:
> > The patch is against current crew. Comments? Ideas? Suggestions?
>
> 1. Brendan did something like this a few months ago.
Do you have some pointer? My archive misses a few months of hg-dev
mails. His version likely is better than mine.
> 2. But: how much slower does this make the templater?
I've timed it:
- with changes:
! wall 2.919978 comb 4.866667 user 4.600000 sys 0.266667 (best of 4)
- without:
! wall 2.829345 comb 4.716667 user 4.450000 sys 0.266667 (best of 4)
For the changed version, I've removed everything that could slow it down
(arguments for keys, made all filters accept two args, etc). I'll see if
I can get that faster.
What loss of performance would be acceptable for such a change to make
it in?
Rocco
More information about the Mercurial-devel
mailing list