[PATCH 2 of 4] graphmod/graphlog: refactor and move common code to graphmod

Peter Arrenbrecht peter.arrenbrecht at gmail.com
Sat May 16 00:07:35 CDT 2009


On Fri, May 15, 2009 at 9:19 PM, timeless <timeless at gmail.com> wrote:
> I know this already got some reviews (i'm behind), but I'd just like
> to point one other thing out, and yes, I'm aware that in some cases
> you're just moving comments.
>
> Peter Arrenbrecht <peter.arrenbrecht at gmail.com> wrote:
>> +def asciiformat(ui, repo, revdag, opts):
>> +    """formats a changelog DAG walk for ascii output"""
>
>> +def asciiedges(nodes):
>> +    """adds edge info to changelog DAG walk suitable for ascii()"""
>
>> +def ascii(ui, dag):
>> +    """prints an ASCII graph of the DAG
>
>>  def goutgoing(ui, repo, dest=None, **opts):
>>     """show the outgoing changesets alongside an ASCII revision graph
>
>>  def gincoming(ui, repo, source="default", **opts):
>>     """show the incoming changesets alongside an ASCII revision graph
>
> IN 3 of 4 non function instances, ASCII is spelled in uppercase (which
> I believe is correct), in one case, it isn't, and in the only other
> item I'm highlighting, it's a function call, which is ok.
>
> I think that asciiformat's comment should use "ASCII output" :)

OK. Forgot to change "elision" anyway.
-parren



More information about the Mercurial-devel mailing list