[PATCH 02 of 10] graphmod/graphlog: move log walks to graphmod

[timeless]

On Fri, May 15, 2009 at 10:16 PM, Peter Arrenbrecht
<peter.arrenbrecht at gmail.com> wrote:
> +    This generator function walks through the revision history from revision
> +    start to revision stop (which must be less than or equal to start).

I know you're just moving this comment and that the variables are
named to match, but i find "start" and "stop" don't seem to fit well.

Since I'm not really sure, this comment is addressed to djc for him to
think about and should not at all affect integration (unless you feel
like explaining it).

start [1] is only available as a verb and a noun,
stop [2] is available as a verb, noun, and adjective.
revision [3] is always a noun

[1] http://www.merriam-webster.com/dictionary/start
[2] http://www.merriam-webster.com/dictionary/stop
[3] http://www.merriam-webster.com/dictionary/revision

Typically in English, you can have <noun phrase> = <adj> <noun>, and
that's a likely thing to appear where the text uses "revision start"
and "revision stop".

Normally, I'd expect start/finish, beginning/end, first/last, but not
start/stop.

Does something like this:
This generator function walks through the revision history from the
first (specified) revision to the last (which must be less than or
equal to start).

... mean what you're trying to say? (and yes, i'm sorry if that means
the variable names are out of sync.)

fwiw, in my mind, revisions don't start or stop :) -- which is part of
the problem with what the current text says :)