[PATCH 1 of 5] inotify: modular architecture for inotify clients

timeless timeless at gmail.com
Sun May 17 00:45:58 CDT 2009


On Thu, May 14, 2009 at 11:15 PM, Nicolas Dumazet <nicdumz at gmail.com> wrote:

> +def start_server(function):
> +    """
> +    Decorator.
> +    Tries to call function, if it fails, try to (re)start inotify server.
> +    Raise QueryFailed if something went wrong

> +    def _receive(self):
> +        """
> +        Read data, check version number, extract headers,
> +        and returns a tuple (data descriptor, header)
> +        Returns (None, None) on error

Just a general question. It seems that you consistently do not include
a period for Returns/Raises lines (that's) fine.

Do you usually try to use a period for the <thing> before the
Raises/Returns line?

It looks like it's a sentence (Read starts with a capital letter, and
there's punctuation).

If it this is supposed to be a sentence, I'd suggest:
+ Read data, check version number, extract headers,
+ and return a tuple (data descriptor, header).

(and yes, that includes return v. returns and the period at the end)



More information about the Mercurial-devel mailing list