[PATCH 02 of 10] graphmod/graphlog: move log walks to graphmod

Matt Mackall mpm at selenic.com
Sun May 17 10:44:42 CDT 2009


On Sat, May 16, 2009 at 10:31:46PM -0700, timeless wrote:
> On Fri, May 15, 2009 at 10:16 PM, Peter Arrenbrecht
> <peter.arrenbrecht at gmail.com> wrote:
> > + ? ?This generator function walks through the revision history from revision
> > + ? ?start to revision stop (which must be less than or equal to start).
> 
> I know you're just moving this comment and that the variables are
> named to match, but i find "start" and "stop" don't seem to fit well.
> 
> Since I'm not really sure, this comment is addressed to djc for him to
> think about and should not at all affect integration (unless you feel
> like explaining it).
> 
> start [1] is only available as a verb and a noun,
> stop [2] is available as a verb, noun, and adjective.
> revision [3] is always a noun
> 
> [1] http://www.merriam-webster.com/dictionary/start
> [2] http://www.merriam-webster.com/dictionary/stop
> [3] http://www.merriam-webster.com/dictionary/revision

The average English speaker (via Google) disagrees:

"start time": 26M hits
"starting time": 22M hits

-- 
Mathematics is the supreme nostalgia of our time.


More information about the Mercurial-devel mailing list